RDR: setting client info #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raaizik
force-pushed
the
rdr-odfinfo
branch
5 times, most recently
from
b6cab4e
to
a77b4e4
Compare
Signed-off-by: raaizik <[email protected]>
Madhu-1
reviewed
Mar 26, 2024
@umangachapagain it's still a WIP |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nb-ohad, raaizik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a0f96b6
into
red-hat-storage:main
10 checks passed
leelavg
added a commit
to leelavg/ocs-client-operator
that referenced
this pull request
Mar 27, 2024
PR red-hat-storage#121 bumped the ocs-op dependency but didn't update the vendor, we had a sub target of go mod tidy and vendor before building image and so CI passed silently and failed d/s where only vendor folder is used. Signed-off-by: Leela Venkaiah G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes to the newly added fields of
ReportStatusRequestwhich are then exported by means of the changes introduced in RDR: exporting client info #2504