Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SIMD helpers:
glmm_min(a, b)
glmm_max(a, b)
simd helpers to match x86, neon and wasm behaviors ( without compromising performance ). I reversed
a
andb
for wasm as @gottfriedleibniz suggested: #361@gottfriedleibniz, @myfreeer a review would be awesome.
In NEON there are also
vminnmq_f32()
/vmaxnmq_f32()
which are similar tovminq_f32()
/vmaxq_f32()
, not sure which is best to use to mimic_mm_min_ps/_mm_max_ps()
.I think since we dont expect NaNs, 'maximum performance' is preferred, any ideas?