Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notion of "notable" types #143

Open
wetneb opened this issue Oct 8, 2023 · 1 comment
Open

Remove notion of "notable" types #143

wetneb opened this issue Oct 8, 2023 · 1 comment

Comments

@wetneb
Copy link
Member

wetneb commented Oct 8, 2023

When returned in suggest responses (and only there), entities currently have a "notable" field containing a list of types.
Because this notion was specific to Freebase, I propose to remove this "notable" field and replace it by a "type" field (still accepting a list of types), for consistency with the stated data model.

@tfmorris
Copy link
Member

tfmorris commented Oct 9, 2023

I think changing the name of the field is fine, but the concept isn't unique to Freebase so I think it's worth keeping the explanatory text saying that this doesn't need to be all the types, but rather just those which are informative to the user in their decision making process. If the service has types like Thing or Object, or types which are just used for administrative uses, those are unlikely to be useful to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants