utils: display warning messages about REANA spec validation #662
Conversation
giuseppe-steduto
force-pushed
the
reana-yaml-allow-unexpected-props
branch
3 times, most recently
from
eedf5fb
to
58c36c1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
==========================================
- Coverage 58.63% 58.53% -0.10%
==========================================
Files 24 24
Lines 2369 2378 +9
==========================================
+ Hits 1389 1392 +3
- Misses 980 986 +6
|
giuseppe-steduto
force-pushed
the
reana-yaml-allow-unexpected-props
branch
2 times, most recently
from
6f839aa
to
2e76db3
Compare
giuseppe-steduto
force-pushed
the
reana-yaml-allow-unexpected-props
branch
from
2e76db3
to
d857753
Compare
reana_client/validation/utils.py
Outdated
| "The REANA specification file is valid, but some warnings were " | ||
| "found. Please check the warnings above and make sure that the " | ||
| "REANA specification file is correct.", |
There was a problem hiding this comment.
Given that we already print the warnings before, maybe we can shorten this to just say Please make sure that the REANA specification file is correct?
Or we could also print something like this:
-> WARNING: Issues found while validating the REANA specification file
-> WARNING: [... list of warnings ...]
-> WARNING: Please make sure that the REANA specification file is correct
In any case, what I would like to avoid is to print a very long line in the terminal.
What do you think?
There was a problem hiding this comment.
Okay for shortening the single lines printed in the terminal! I think it is still important to write that the REANA specification file appears valid.
There was a problem hiding this comment.
Maybe let's add a line to CHANGES.rst?
giuseppe-steduto
force-pushed
the
reana-yaml-allow-unexpected-props
branch
2 times, most recently
from
13d6dcd
to
769a840
Compare
giuseppe-steduto
force-pushed
the
reana-yaml-allow-unexpected-props
branch
from
769a840
to
15a01ad
Compare
Closes #660