New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

third-party lib ZIP (different in LCP client) #232

Open

danielweck opened this issue Apr 1, 2016 · 4 comments

Labels

func:DRM func:Zip priority:High type:Bug

Member

danielweck commented Apr 1, 2016

ReadiumSDK:
https://github.com/readium/readium-sdk/tree/develop/ePub3/ThirdParty/libzip

versus

LCP:
https://github.com/readium/readium-lcp-client/tree/android/src/third-parties/ziplib

Problem: what about the pending 64bits large ZIP file PR?
#106
#191

Member Author

danielweck commented Apr 1, 2016

Member

rkwright commented Apr 1, 2016

What is the provenance of the LCP ziplib? There is no documentation there, nor a license or any indication where it came from.

Member Author

danielweck commented Apr 1, 2016

https://bitbucket.org/wbenny/ziplib

http://mindless-area.blogspot.co.uk/2013/06/ziplib-lightweight-c11-library-for.html

Member Author

danielweck commented Apr 1, 2016

...and it's actually a stream wrapper for several compression algorithms / libs, for example zlib:
https://github.com/readium/readium-lcp-client/tree/android/src/third-parties/ziplib/Source/ZipLib/extlibs/zlib

danielweck mentioned this issue

third-party lib ZIP (different in Readium SDK) readium/readium-lcp-client#8

Open

rkwright added func:DRM func:Zip priority:Blocking type:Bug labels

rkwright added priority:High and removed priority:Blocking labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment