Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: tracking of "web readers", support for zipped and exploded EPUBs, RWPM etc. #36

Open
danielweck opened this issue Nov 30, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@danielweck
Copy link
Member

Hello, I updated the "registry" documented here:

edrlab/publications#2

Direct link to "Readium Playground":

edrlab/publications#2 (comment)

(scroll all the way down to see the successful Go streamer RWPM, and the failing TS/JS streamer RWPM)

@JayPanoz
Copy link
Contributor

JayPanoz commented Dec 2, 2024

@danielweck Thanks! Will take a look later this week since there’s something else I have to check for the positions list. 🙏

@danielweck
Copy link
Member Author

If indeed the absence of "positions list" in the RWPM JSON generated by the old JS/TS streamer is what is causing the web reader to crash, then is this intentional design, or just an oversight? I am trying to understand if the Readium specification requires this feature:

https://readium.org/architecture/models/locators/positions/

@JayPanoz JayPanoz added the bug Something isn't working label Dec 2, 2024
@JayPanoz
Copy link
Contributor

JayPanoz commented Dec 2, 2024

is this intentional design, or just an oversight?

That would be an oversight as it was initially working w/o it. I’m consequently labelling this issue as a bug and will fix this issue ASAP.

@chocolatkey
Copy link
Member

chocolatkey commented Dec 3, 2024

For the purposes of the ts-toolkit, I have been assuming that it always exists because I've always been working with the go-toolkit's output. Because the position list for reflowable is calculated based on the file size of the resources, which is not present in the manifest, it is "required" in order for the navigator implementation in the ts-toolkit to work properly at the moment. We could alter that if necessary

@JayPanoz
Copy link
Contributor

JayPanoz commented Dec 3, 2024

So yeah the unhandled Promise rejection seems to be here in ts-toolkit.

Would you like to migrate the issue to ts-toolkit? Or should we wait Wednesday’s call to discuss this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Draft
Development

No branches or pull requests

3 participants