Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review process #5

Open
ltmylinh opened this issue Feb 9, 2019 · 4 comments
Open

Review process #5

ltmylinh opened this issue Feb 9, 2019 · 4 comments

Comments

@ltmylinh
Copy link
Collaborator

ltmylinh commented Feb 9, 2019

This issue is created to discuss about review process:

  • How many approvals do we need for a PR?
  • Who will take responsibility to merge PR?
@nampdn
Copy link
Collaborator

nampdn commented Feb 9, 2019

  • To make the review process solid, I think we should have at least 1 approval.

  • At this time, we are only 2 maintainers, I think both of us can merge if a PR is approved.

@ltmylinh
Copy link
Collaborator Author

ltmylinh commented Feb 9, 2019

I prefer at least 2 approvals. More reviewers will have good quality.
We have @anhphamduy in our team, right?

@Quynh-Nguyen
Copy link
Contributor

@nampdn @ltmylinh
Hi bros,
Can I join this project? I will help translate at night.

@huyqdang
Copy link

Yo yo, I want to help as well.

Ryan-LT pushed a commit that referenced this issue Sep 21, 2021
@danglequocbao001
Merge pull request #5 from reactjs/main
0890690 
chore: pull code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ltmylinh @Quynh-Nguyen @huyqdang @nampdn