Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React without ES6 guide translation #123

Merged
merged 21 commits into from
Jan 16, 2020

Conversation

wogsland
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for de-reactjs ready!

Built with commit 9eb0dc5

https://deploy-preview-123--de-reactjs.netlify.com

Copy link
Contributor

@jakeherp jakeherp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few grammatical annotations

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@wogsland
Copy link
Contributor Author

wogsland commented Jan 13, 2020

It looks like most of my PR has been deleted in the merge in favor of another's translation of this page? Is this PR still relevant?

@wogsland wogsland requested a review from ph1p January 13, 2020 12:07
@ph1p
Copy link
Member

ph1p commented Jan 13, 2020

It looks like most of my PR has been deleted in the merge in favor of another's translation of this page? Is this PR still relevant?

I was also wondering, because I reviewed the exact same page 3 days ago.(#105)
Your right. (#1 (comment))

That wasn't supposed to happen, and I'm sorry. I made a few corrections and I will merge them.

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@ph1p ph1p merged commit 1436c02 into reactjs:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants