Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate react without es6 #105

Merged
merged 25 commits into from
Jan 10, 2020
Merged

Translate react without es6 #105

merged 25 commits into from
Jan 10, 2020

Conversation

amelieoller
Copy link
Contributor

No description provided.

@amelieoller amelieoller mentioned this pull request Oct 16, 2019
Closed
91 tasks
@netlify
Copy link

netlify bot commented Oct 16, 2019 •
edited
Loading

Deploy preview for de-reactjs ready!

Built with commit af22e6c

https://deploy-preview-105--de-reactjs.netlify.com

@miku86 miku86 self-assigned this Oct 27, 2019
miku86
miku86 requested changes Oct 27, 2019
View reviewed changes
Copy link
Member

@miku86 miku86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amelieoller

Hey Amelie,

thanks for your contribution!
I've made some suggestions,
please go over them.

If you have some better suggestions,
feel free to comment in my suggestions.

Greetings
Michael

@miku86 miku86 removed their assignment Oct 27, 2019
@miku86 miku86 added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Oct 27, 2019
amelieoller and others added 8 commits November 6, 2019 09:17
@ph1p ph1p added the idle This PR is idle and the creator has not touched it for a long time. label Nov 17, 2019
ph1p
ph1p requested changes Dec 19, 2019
View reviewed changes
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@ph1p ph1p removed the idle This PR is idle and the creator has not touched it for a long time. label Dec 19, 2019
amelieoller and others added 10 commits December 27, 2019 14:54
@amelieoller @ph1p
Update content/docs/react-without-es6.md
db41f56 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
d147cff 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
11a73f0 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
c23e108 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
33baddc 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
b95caa9 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
036b573 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
1de168d 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
d4ec313 
Co-Authored-By: Phil <[email protected]>
@amelieoller @ph1p
Update content/docs/react-without-es6.md
20d5d25 
Co-Authored-By: Phil <[email protected]>
@ph1p
Copy link
Member

ph1p commented Jan 10, 2020

Please take a look the last 4 open suggestions and we can merge this translation. Thank you (:

@amelieoller
Copy link
Contributor Author

Sorry about that Phil, didn't realize there was more :) - Thanks for reviewing! Let me know if there is anything else I missed

@ph1p
Copy link
Member

ph1p commented Jan 10, 2020

Sorry about that Phil, didn't realize there was more :) - Thanks for reviewing! Let me know if there is anything else I missed

No problem. It's really easy to miss. The auto-folding is an annoying thing at Github :/
Anyway... Thanks for your translation! :)

@ph1p ph1p merged commit 9934fbc into reactjs:master Jan 10, 2020
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Jan 10, 2020
@amelieoller
Copy link
Contributor Author

Yes, I think the auto-fold is what I missed. Happy to help :)

@ph1p ph1p mentioned this pull request Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miku86 miku86 miku86 requested changes

@ph1p ph1p ph1p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amelieoller @ph1p @miku86