Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getScrollAccessor on window seems wrong #131

Open
satazor opened this issue Aug 25, 2020 · 1 comment
Open

getScrollAccessor on window seems wrong #131

satazor opened this issue Aug 25, 2020 · 1 comment
Labels
bug

Comments

@satazor
Copy link

satazor commented Aug 25, 2020

dom-helpers/src/getScrollAccessor.ts

Line 19 in 536ae60

win.scrollTo(win[offset], val)

When offset is pageYOffset, scrollTo will be invoked with scrollTo(currentPageYOffset, newPageYOffset). When offset is pageXOffset, scrollTo will be invoked with scrollTo(currentPageXOffset, newPageXOffset).

This doesn't seem to be right. What we want to do is to preserve the value of X when we are changing Y and vice-versa.
@satazor satazor changed the title getScrollAccessor when window seems wrong getScrollAccessor on window seems wrong Aug 25, 2020
@jquense
Copy link
Member

jquense commented Aug 25, 2020

ya seems like a bug!

@jquense jquense added the bug label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jquense @satazor