Skip to content
This repository has been archived by the owner on Jun 21, 2021. It is now read-only.

Refinements for Confluence #11

Merged
merged 1 commit into from
May 10, 2015
Merged

Refinements for Confluence #11

merged 1 commit into from
May 10, 2015

Conversation

aheusingfeld
Copy link
Contributor

Added some conversion in respect to #9

  • extracted all asciidoc specific conversion into the "parseBody()" function
  • added conversion of code blocks to code macro
  • added conversion for admonitions TIP, CAUTION, NOTE, WARNING and IMPORTANT including their title into Confluence macro
  • removed unnecessary wrapping divs (.paragraph, .ulist, .sect3, .listingblock, .title) as these cause Confluence to omit the margin between the paragraphs
  • upgraded JSoup from 1.7.3 to 1.8.2

@aheusingfeld
Refinements for Confluence
4bf0a20 
Added some conversion in respect to rdmueller#9
- extracted all asciidoc specific conversion into the "parseBody()" function
- added conversion of code blocks to code macro
- added conversion for admonitions TIP, CAUTION, NOTE, WARNING and IMPORTANT including their title into Confluence macro
- removed unnecessary wrapping divs (.paragraph, .ulist, .sect3, .listingblock, .title) as these cause Confluence to omit the margin between the paragraphs
rdmueller added a commit that referenced this pull request May 10, 2015
@rdmueller
Merge pull request #11 from aheusingfeld/master
cb40f9b 
Refinements for Confluence
@rdmueller rdmueller merged commit cb40f9b into rdmueller:master May 10, 2015
@rdmueller
Copy link
Owner

Thanx for the contribution! I'll add my code to the toc in just a minute - I think #9 will then be ready to be closed...

rdmueller added a commit that referenced this pull request May 10, 2015
@rdmueller
issue #9
ead1659 
- added toc for each page

pr #11
- removed debug dump
- replace log.info with println
@rdmueller
Copy link
Owner

hm. something went wrong - at least for me...

can't get it to work anymore. With a slight change of the code, the master page will be created but for the next one I get the following error:

something went wrong - got an https response code 400:
[data:[authorized:false, errors:[], valid:true], message:Error parsing xhtml, statusCode:400]

Does it work for you?

@aheusingfeld
Copy link
Contributor Author

Oh, I forgot to check the "confluenceCreateSubpages = true" tests. Sorry. Will check later today

@rdmueller
Copy link
Owner

found the problem... was really hard to find:

the new version outputs html, not xhtml => <hr>!=<hr />
This leads to the exception above. will open a new issue...

@rdmueller
Copy link
Owner

just commited some fixes - subpages work, updates work and xhtml partly works...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aheusingfeld @rdmueller