Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firedrake is not installed with requirements #8

Open
jonwittmer opened this issue Apr 10, 2023 · 2 comments
Open

Firedrake is not installed with requirements #8

jonwittmer opened this issue Apr 10, 2023 · 2 comments

Comments

@jonwittmer
Copy link
Collaborator

The hardest part of installation is left manually to the user. The presence of a requirements.txt file is misleading if one of the main components is missing.

@rckirby
Copy link
Owner

rckirby commented Apr 28, 2023

Firedrake installation is tricky but could be worse. Unless firedrake becomes pip installable. At least the requirements.txt lets the user know what is required and easy to install.

A way forward is to embed torchfire installation into firedrake so one runs firedrake-install --install torchfire as the recommended installation pathway. Then the dependence on firedrake is solved automatically. Thoughts?

@jonwittmer
Copy link
Collaborator Author

I like the idea of embedding torchfire in the firedrake installation process. This reduces the number of steps a user needs to take in order to have a working installation.

It would also be nice to provide a docker container with all the dependencies installed, though I think we should still make it as easy as possible to install torchfire manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants