Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metasploit companion for rex-core #32 #17495

Conversation

sempervictus
Copy link
Contributor

@sempervictus sempervictus commented Jan 18, 2023

Using Rex' various gems without Msf will result in errors when the logging subsystem is undefined (as that remained in Msf during the great Rex excision). This manifests in rex-socket as noted by @zeroSteiner in rapid7/rex-socket#38.

Address the dependency problem by moving rex/logging into rex-core which is already required by rex-socket and other descendants.

Notes:
This PR is staged to allow rapid7/rex-core#32 to be merged without creating a (seemingly harmless) redundancy.

Using Rex' various gems without Msf will result in errors when the
logging subsystem is undefined (as that remained in Msf during the
great Rex excision). This manifests in rex-socket as noted by
@zeroSteiner in rapid7/rex-socket#38.

Address the dependency problem by moving rex/logging into rex-core
which is already required by rex-socket and other descendants.

Notes:
  This PR is staged to allow github.com/rapid7/rex-core/pull/32
to be merged without creating a (seemingly harmless) redundancy.
@sempervictus
Copy link
Contributor Author

Those test failures are expected, i disemboweled logging in this commit until the testbeds have that rex-logging PR 😄

@gwillcox-r7
Copy link
Contributor

@sempervictus To clarify does this rely on rapid7/rex-core#32 being merged first? Going to add a delayed tag for now under the assumption that is the case, but feel free to correct me if not.

@gwillcox-r7 gwillcox-r7 added the blocked Blocked by one or more additional tasks label May 2, 2023
@adfoster-r7
Copy link
Contributor

Will close this off to keep the PR queue tidy; it looks like there's more work required in other places to actually wire this up correctly (context) - regardless of preserving Git history 👍

Just for a paper trail: Cross-referencing the other test PR #17506 (comment) which I think had more of the missing pieces than this PR

@adfoster-r7 adfoster-r7 closed this Jun 9, 2023
@adfoster-r7 adfoster-r7 added the attic Older submissions that we still want to work on again label Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it attic and closed it for now.

What does this generally mean? It could be one or more of several things:

  • It doesn't look like there has been any activity on this pull request in a while
  • We may not have the proper access or equipment to test this pull request, or the contributor doesn't have time to work on it right now.
  • Sometimes the implementation isn't quite right and a different approach is necessary.

We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attic Older submissions that we still want to work on again blocked Blocked by one or more additional tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants