-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modal
components are incompatible with third-party modals
#2219
Comments
Encountering the same issue. I've tried preventing default in |
This may not be an option for all projects, especially when the entirety of the UI is not implemented using Radix. On top of that, browser overlays and browser extensions may not work properly too, which is not good. |
I agree. I think we're just missing a way to remove the focus trap on demand. |
I managed to make it work by setting the I agree it would be nicer to just have an option to remove the focus trap on demand. |
@JesseKuntz @ciampo it was so much gymnastics just to get that too work properly I just created my own dialog. Haha. I am using the next-cloudindary widget to upload images which opens up in its own modal. Hopefully this will get fixed soon as this is a common scenario. |
I'm also encountering this issue. In my case, the issue is not being able to get pointer events when the Dialog is open. |
I'm having the same problem. I have a modal with a login form and all password managers like NordPass become unclickable cause the body sets pointer-events to none. Any updates on this? Seems quite like a pretty common scenario in general. |
A quick fix for me was to add this to the css:
(Thank you ChatGPT) |
Duplicate of #1859 |
Bug report
Current Behavior
When using any components supporting the option to render as
modal
, other third-party pieces of UI that would need to also render as modal on top of the radix component stop working as expected, due to the pointer events / scroll / focus trap that Radix components create.This makes it practically impossible to integrate Radix in existing projects, where not all UI elements are using Radix.
Furthermore, this also breaks browser extensions (like Grammarly or Google Translate) that would display additional UI when activated.
Expected behavior
There should be a way for third-party "Modal" content to render and be interactive of top of Radix's modal components.
Reproducible example
https://codesandbox.io/s/interesting-julien-9lr83p
Suggested solution
Additional context
Your environment
The text was updated successfully, but these errors were encountered: