Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-prescient-retain-classic-highlighting seems to not work in some situations #48

Open
Vonfry opened this issue Nov 16, 2019 · 2 comments
Labels

Comments

@Vonfry
Copy link

Vonfry commented Nov 16, 2019

Description

In some special situations, ivy-prescient-retain-classic-highlighting seems to not work as description in #11 .

First, let us see the correct color in my config with ivy-prescient-retain-classic-highlighting. In this situation, I search a simple string and get the correct highlighting color for results.

image with correct color

And if searching with regexp, the ivy-prescient-retain-classic-highlighting appears to be back to setting nil.

image with incorrect color

Reproduce:

First

;; $ emacs -Q # and run in ielm or in init.el

(add-to-list 'load-path <some-path such as ivy, prescient, ivy-prescient>)

(require 'ivy)
(ivy-mode t)
(require 'ivy-prescient)
(setq ivy-prescient-retain-classic-highlighting t)
(ivy-prescient-mode t)

Second

Compare with M-x -> ivy.* and M-x -> ivy.

@raxod502
Copy link
Member

Thanks for the report. Just to clarify, you observe different highlighting behavior if you are using stock Ivy to search for a regexp, without ivy-prescient.el?

@raxod502 raxod502 added the bug label Nov 16, 2019
@Vonfry
Copy link
Author

Vonfry commented Nov 17, 2019

Run emacs -Q

Without ivy-prescient.el:

image

image

With ivy-prescient.el and ivy-prescient-retain-classic-highlighting:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants