Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

company-lsp example: is it still appropriate/relevant? #160

Open
rdiaz02 opened this issue Mar 15, 2024 · 2 comments
Open

company-lsp example: is it still appropriate/relevant? #160

rdiaz02 opened this issue Mar 15, 2024 · 2 comments

Comments

@rdiaz02
Copy link

rdiaz02 commented Mar 15, 2024

In https://github.com/radian-software/prescient.el#for-company we are told:

"By customizing this user option to nil for such Company backends (see Radian for an example)"

and the example code uses company-lsp, but company-lsp is no longer supported : https://emacs-lsp.github.io/lsp-mode/#overview " (note that company-lsp is no longer supported)." Also tigersoldier/company-lsp#145 (comment) (from LSP developer, August 2020).

So I wonder if:

  1. The problem is still present (does not seem so in my very limited testing with only a few languages)
  2. If the problem should be addressed via a package that is no longer supported.

(Note: this is strongly related to similar comments in radian-software/radian#535)

@raxod502
Copy link
Member

Well, no comment is made on the prescient.el side about company-lsp specifically, it is just that that is what is used on the Radian side. No objection to using a different example, if there is another good one.

@rdiaz02
Copy link
Author

rdiaz02 commented Mar 23, 2024

My suggestion would be to comment out in here since: a) I think the problem is not present; b) it refers to a package no longer supported. But then, I am not 100% sure. So, of course, feel free to close this as irrelevant noise if it is :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants