Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrlf C-g should not close occur window #98

Open
legendre6891 opened this issue Jul 29, 2021 · 3 comments
Open

Ctrlf C-g should not close occur window #98

legendre6891 opened this issue Jul 29, 2021 · 3 comments

Comments

@legendre6891
Copy link

Hi there — this is a great package!

May I make one feature request? When I use M-s o to occur the current search input, and subsequently use C-g to quit, the occur buffer is closed.

Could we keep the occur buffer around even after C-g? (Or introduce an option for this?) I believe this is how standard isearch behaves.

Thanks!

@Lenbok
Copy link

Lenbok commented Aug 16, 2021

In fact, I really like how swiper handles this: when you are in the middle of a search and activate the ivy-occur action, it stops the current search and leaves you in the occur buffer.

I'm not sure what the use case is for the current ctrlf behaviour where the occur buffer pops up, but the search continues, and the occur buffer closes when the search is terminated. (Happy to be educated about the expected workflow)

@raxod502
Copy link
Member

raxod502 commented Oct 19, 2021

Sounds fine to me---I wasn't the one to implement the occur integration (it's from #48), and I agree that the current behavior seems confusing. Maybe @andschwa can comment on whether it's intentional, or the result of a bug in how minibuffer handling works.

@andyleejordan
Copy link
Contributor

Oh no, I don't remember at all 😅 if it's not how the built-in isearch or occur works, then it likely wasn't intentional, I tried to match it as closely as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants