Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare also against swiper-isearch in README #39

Open
a13 opened this issue Mar 31, 2020 · 12 comments
Open

Compare also against swiper-isearch in README #39

a13 opened this issue Mar 31, 2020 · 12 comments

Comments

@a13
Copy link

a13 commented Mar 31, 2020

here https://github.com/raxod502/ctrlf#why-not-swiper you didn't mention swiper-isearch, which was introduced a year ago

@raxod502 raxod502 changed the title please fix swiper comparison Compare also against swiper-isearch in README Mar 31, 2020
@raxod502
Copy link
Member

Reasonable.

@aspiers
Copy link

aspiers commented Dec 15, 2020

Also, having used swiper for quite a while, and having only just switched to ctrlf today (BTW I love it already!), I find the argument in that section unnecessarily weak. It says:

The selling point of Swiper is that it shows you an overview of the matches. Ask yourself: when was the last time you actually got anything useful out of that overview?

Actually, I find that overview incredibly useful, multiple times pretty much every day. However consult-line is a perfect substitute (and also proof that at least one other person finds that functionality useful). So I suggest rephrasing that argument.

@aspiers
Copy link

aspiers commented Dec 15, 2020

Maybe also worth noting that the weakness of that argument delayed my switch to ctrlf by several months. Now I'm feeling regret for the delay ;-)

@a13
Copy link
Author

a13 commented Dec 16, 2020

Also, having used swiper for quite a while

The question here is not about swiper but about swiper-isearch, which does everything (I suppose) ctrlf can do and even more.

Now I'm feeling regret for the delay ;-)

what for?

@a13
Copy link
Author

a13 commented Dec 16, 2020

Maybe also worth noting that the weakness of that argument delayed my switch to ctrlf by several months. Now I'm feeling regret for the delay ;-)

taking into account that there is (and existed before ctrlf was "invented") swiper-isearch, that section should be empty since

Furthermore, Swiper constrains itself almost exclusively to line-based search by design, which makes it unsuitable to the task of quick movement within a line or movement to a commonly occurring search string.

argument is not valid either

@raxod502
Copy link
Member

I find the argument in that section unnecessarily weak

Fair enough. I will note that other people have said they agree with it, so I think whether or not the overview is helpful depends on the individual person. It makes sense to make this subjectivity explicit in the README.

Now I'm feeling regret for the delay ;-)

What information could have been available that would have communicated the changes of CTRLF that matter to you personally? Or was it just that the note about the overview not being helpful seemed very wrong to you, and hence you didn't look further?

@aspiers
Copy link

aspiers commented Dec 22, 2020

@raxod502 commented on December 21, 2020 11:01 PM:

I find the argument in that section unnecessarily weak

Fair enough. I will note that other people have said they agree with it, so I think whether or not the overview is helpful depends on the individual person. It makes sense to make this subjectivity explicit in the README.

Agreed 👏

Now I'm feeling regret for the delay ;-)

What information could have been available that would have communicated the changes of CTRLF that matter to you personally?

Well the first thing I really liked was the ability to navigate multiple matches within a single line, but that was before I realised that swiper-isearch existed. The other thing I like is seeing the count of matches right next to the match. Other than that and the overview, I'm not sure there are huge differences with swiper-isearch.

Or was it just that the note about the overview not being helpful seemed very wrong to you, and hence you didn't look further?

Yeah pretty much, but that was also before I learned that I could get an overview from occur (which is kind of crazy and embarrassing given that I've used emacs since 1994). If #69 was addressed then I would not miss the absence of an overview being displayed in the minibuffer by default.

@a13
Copy link
Author

a13 commented Dec 23, 2020

I like is seeing the count of matches right next to the match

like this?

screenshot

@a13
Copy link
Author

a13 commented Dec 23, 2020

It makes sense to make this subjectivity explicit in the README.

In such case the phrasing isn't perfect. Something like "I don't use it" would sound more stainless (to me)

@aspiers
Copy link

aspiers commented Dec 23, 2020

@a13 commented on December 23, 2020 8:50 AM:

I like is seeing the count of matches right next to the match

like this?

No, that's not right next to the match.

@raxod502
Copy link
Member

right next to the match

I'm assuming you mean this functionality of CTRLF, which displays the match count and index within the buffer, rather than only the minibuffer:

image

@aspiers
Copy link

aspiers commented Dec 28, 2020

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants