feat: New allow_na_rows_affected tweak to support NA values returned from dbGetRowsAffected()
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
aviator-app
bot
force-pushed
the
f-297-rows-affected-na
branch
from
62cbe42
to
b2ed3b6
Compare
krlmlr
force-pushed
the
f-297-rows-affected-na
branch
from
b2ed3b6
to
388749b
Compare
aviator-app
bot
force-pushed
the
f-297-rows-affected-na
branch
from
388749b
to
05edff5
Compare
|
This works with RSQLite, should also work for us. Merging, happy to discuss after the fact. |
…ned from `dbGetRowsAffected()`
aviator-app
bot
force-pushed
the
f-297-rows-affected-na
branch
from
05edff5
to
c31f8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297.