Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a (private?) function for each method and check the input values #29

Open
BoxiLi opened this issue Nov 22, 2024 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@BoxiLi
Copy link
Member

BoxiLi commented Nov 22, 2024

The optimize_pulses method now is very general, similar to the scipy.optimize.minimize. Unfortunately, different control methods have very different input formats, e.g. GRAPE takes no initial pulse guess, CRAB's pulse guess is the full pulse amplitude array, GOAT and JOPT need initial parameters for the analytical pulse function. There is no way to unify them. The input value is not sufficiently checked right now for optimize_pulse, input values get ignored and not passed to the algorithm. It is better to check those in each individual control function.

@flowerthrower flowerthrower added the good first issue Good for newcomers label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants