-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to project sorting #1537
Comments
Can somewhat resolve item 2 by adding this: ImageRow selectedImageRow = getSelectedImageRow();
refreshTree(selectedImageRow); to the end of |
Seems like 1. might require changing the |
Yes. We can make changes, but need to be cautious and ideally keep the The thinking is that we want projects to not necessarily be backed by files on the local file system. So you might have a QuPath project that behaves like a 'view' on an OMERO project (for example). I think this idea is already used by QuPath Edu - see here. |
An alternative could be to smuggle in an implementation of stored sorting with a The obvious way to make one change that permits any future extensions is to add a |
Yes, map is tempting but a bit scary. |
Actually wondering is this so bad after all? Could have a class that manages sorting by metadata key(s), then use a manager to store/retrieve associated settings for the project in [something, maybe a file]. Not too dissimilar philosophically to loading/saving classifiers in the grand scheme of things |
True. I'm not a big fan of managers, especially if we just expect to store one value, but it should work without needing to change much. Or what do you think of a project supporting Thinking about it, we could also easily add a Although now that I think about that, it couldn't really be applied to |
My thought was to store an in theory arbitrary amount of grouping/sorting keys (but realistically only up to 2 or 3) that can be applied sequentially, as well as whether each is used in ascending or descending order. This would let us handle the nested grouping/sorting described in #1289 The advantage here is we're free to save whatever we need into the manager's save state without needing to revisit project if we add new grouping features.
This has its own kind of code smell I think, but yeah doesn't have as many issues as handling |
Feature request
Is your feature request related to a problem? Please describe.
Project sorting is not persistent across QuPath instances, and does not update based on updated metadata values.
Nice-to-have would be to add metadata values when images are dragged and dropped, but I feel that's going to be a stretch goal.
Describe the solution you'd like
In order of priority/feasibility:
Describe alternatives you've considered
Manually re-sorting on project opening and when values change, and manually setting metadata values.
Additional context
ImageSC posts:
The text was updated successfully, but these errors were encountered: