Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse warnings in connectors/wsclient-javax-websocket #89

Open
ddebrunner opened this issue Mar 3, 2016 · 4 comments
Open

Eclipse warnings in connectors/wsclient-javax-websocket #89

ddebrunner opened this issue Mar 3, 2016 · 4 comments
Assignees

Comments

@ddebrunner
Copy link
Contributor

The Dummy file causes a warning in eclipse.

The resource is a duplicate of wsclient/src/test/java/Dummy and was not copied to the output folder

Any reason a different style to the other Dummy tests was taken?

@dlaboss
Copy link
Member

dlaboss commented Mar 4, 2016

Sorry, hadn't noticed that among the Window test warnings :-)
I'll revert it to the DummyTest.java scheme. I originally switched because it seemed like a dummy java file and generated class were overkill for the goal of having something in src/test/java to make the ant scripts work. I had a bundle (javax.websocket-server) that didn't have any src/main/java code, the jar was just a manifest-classpath aggregator for ext jars, and didn't want a dummy class included in the jar. Hmm just occurred to me that might instead just be able to make the ant scripts create the necessary dir if it doesn't exist (e.g., component-path/src/test/java) so everything just works w/o the need for dummies. I'll give that more thought when I do issue #86.

@ddebrunner
Copy link
Contributor Author

The DummyTest were intended as a placeholder until tests were actually written.

@dlaboss
Copy link
Member

dlaboss commented Mar 24, 2016

Fixed by #104 and #86

@dlaboss
Copy link
Member

dlaboss commented Mar 24, 2016

@ddebrunner pls close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants