Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solve_lmde_perturbation work with non-integer labels #306

Open
DanPuzzuoli opened this issue Jan 22, 2024 · 1 comment
Open

Update solve_lmde_perturbation work with non-integer labels #306

DanPuzzuoli opened this issue Jan 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DanPuzzuoli
Copy link
Collaborator

What is the expected behavior?

Currently the solve_lmde_perturbation function requires that the labels for the perturbations be non-negative integers. It would be nice to allow more general labels, e.g. strings that can directly name what the perturbation represents.

This could either be done by having a translation of arbitrary labels <-> integers before/after the core of the function is executed, or by modifying the actual internals to work with more general labels. The latter would be more elegant, though it'll likely be much easier to do the former. (I can't recall how much of the internals make use of integer properties.)

@DanPuzzuoli DanPuzzuoli added the enhancement New feature or request label Jan 22, 2024
@DanPuzzuoli
Copy link
Collaborator Author

I was going to try to do this right now but it's not urgent and may make sense to just wait until after arraylias integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant