Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI default background color #21894

Open
anddam opened this issue Nov 22, 2024 · 3 comments
Open

WebUI default background color #21894

anddam opened this issue Nov 22, 2024 · 3 comments
Labels
Look and feel Affect UI "Look and feel" only without changing the logic WebUI WebUI-related issues/changes

Comments

@anddam
Copy link

anddam commented Nov 22, 2024

qBittorrent & operating system versions

qBittorrent: v5.0.2 (I guess, that's what WebUI's About dialog says)
Operating system: Void Linux
Qt: 6.8.0
Libtorrent: 1.2.19.0

Additional deps:
Boost: 1.86.0
OpenSSL: 3.4.0
zlib: 1.3.1.zlib-ng

What is the problem?

The CSS seems to rely on browsers default white background color, thus uses rgb(0,0,0,0) where it means "white".

When embedded in an iframe with a different background (e.g. in Organizr) this results in very poor readability.

The app should set the base background color it relies on, for instance setting background color: white on body element

Steps to reproduce

  1. start webui
  2. open inspector
  3. select body element
  4. add background-color: black; to the element style
  5. enjoy the headache

Additional context

Screenshot 2024-11-22 162126

Log(s) & preferences file(s)

There are no logs or preference involved.

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Nov 22, 2024

Yeah, that's another consequence of not setting the background color explicitly.

@skomerko, @Piccirello, maybe we just drop in the background color.
Regarding a particular color choice, as mentioned in #21498 (comment), we could use one that Chrome picks - #121212.
And maybe light theme background should be explicitly set too, just in case.

@thalieht thalieht added WebUI WebUI-related issues/changes Look and feel Affect UI "Look and feel" only without changing the logic labels Nov 22, 2024
@anddam
Copy link
Author

anddam commented Nov 23, 2024

And maybe light theme background should be explicitly set too, just in case.

Yes, notice that unlike PR #21498 my report is not for dark theme, what you see in the screenshot is the default light theme, only within Organizr that has a black background by default.

This is the same page accessed directly, with Chrome using a white background color

Screenshot 2024-11-23 224156

@skomerko
Copy link
Contributor

skomerko commented Nov 25, 2024

Will #21914 be enough to fix your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Look and feel Affect UI "Look and feel" only without changing the logic WebUI WebUI-related issues/changes
Projects
None yet
Development

No branches or pull requests

4 participants