Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export utility functions #9

Open
puwelous opened this issue Feb 20, 2020 · 4 comments
Open

Export utility functions #9

puwelous opened this issue Feb 20, 2020 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@puwelous
Copy link

puwelous commented Feb 20, 2020

Hello 👋

When writing our own macro-decorators, we found out we would like to use utility functions like getPath(), getPaths(), etc. internally used in https://github.com/pzuraq/macro-decorators/blob/master/src/index.ts.

Would it make sense for you to make them publicly available?

@pzuraq
Copy link
Owner

pzuraq commented Feb 20, 2020

Sure, I think that'd be good. Maybe we can export them from macro-decorators/util?

@puwelous
Copy link
Author

Yup, very well 👍

@pzuraq
Copy link
Owner

pzuraq commented Feb 23, 2020

PRs welcome! I'll try to get to this soon, but this would be a great issue for a new contributor

@pzuraq pzuraq closed this as completed Feb 23, 2020
@pzuraq pzuraq reopened this Feb 23, 2020
@pzuraq pzuraq added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 23, 2020
@puwelous
Copy link
Author

puwelous commented Feb 23, 2020

#10 Have I forgotten anything?

ℹ️ I placed them into /src/utils instead of /src/util as other ember utility classes or addons have similar export path, i.e. @ember/utils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants