Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models.py python style guide edits #637

Open
1 task done
Robert-Collins-CS opened this issue Nov 22, 2024 · 1 comment
Open
1 task done

models.py python style guide edits #637

Robert-Collins-CS opened this issue Nov 22, 2024 · 1 comment

Comments

@Robert-Collins-CS
Copy link

Checklist

Safety version

3.2.11

Python version

3.9

Operating System

Windows 11

Describe the problem you'd like to have solved

When running the models.py file through flake8 and pylint, I discovered that there were many, many python style guide issues that could be avoided and hopefully rectified. I believe that editing the code to adhere more to the python style guide to help with code readability for developers and maintainers could be a useful use of time.

Describe the ideal solution

The ideal solution is to attempt to refactor the code in order to adhere more to the python style guide and help with code readability and hopefully even manageability. This is just a matter of editing the code to fix the issues that occurred from the pylint and flake8 inspection I conducted.

Alternatives and current workarounds

I have not considered any alternatives or work arounds as this issue is mainly cosmetic and I do not foresee any solutions besides code refactoring.

Additional context

pylintreview
flake8review

What I Did

I ran the models.py file through 2 different code inspection programs to help me determine code smells and issues with code that variated from the python style guide in order to see how readable the code was! That is where the screenshots came from.

Copy link

Hi @Robert-Collins-CS, thank you for opening this issue!

We appreciate your effort in reporting this. Our team will review it and get back to you soon.
If you have any additional details or updates, feel free to add them to this issue.

Note: If this is a serious security issue that could impact the security of Safety CLI users, please email [email protected] immediately.

Thank you for contributing to Safety CLI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant