Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum typer version #563

Open
Iain-S opened this issue Aug 6, 2024 · 1 comment
Open

Add minimum typer version #563

Iain-S opened this issue Aug 6, 2024 · 1 comment

Comments

@Iain-S
Copy link

Iain-S commented Aug 6, 2024

Although typer is still in 0.x.y, it would be of benefit to have a minimum version specified in setup.cfg.
This line, for example, imports MarkupMode, which was not in typer.core until 0.6.0.

from typer.core import TyperGroup, TyperCommand, MarkupMode

Could we change setup.cfg to be

typer>=0.6.0

I'm happy to verify the exact minimum version though I guess that's subject to constant change.

Copy link

github-actions bot commented Aug 6, 2024

Hi @Iain-S, thank you for opening this issue!

We appreciate your effort in reporting this. Our team will review it and get back to you soon.
If you have any additional details or updates, feel free to add them to this issue.

Note: If this is a serious security issue that could impact the security of Safety CLI users, please email [email protected] immediately.

Thank you for contributing to Safety CLI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant