Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPO slow start #2044

Open
felipemello1 opened this issue Nov 21, 2024 · 0 comments
Open

PPO slow start #2044

felipemello1 opened this issue Nov 21, 2024 · 0 comments
Assignees

Comments

@felipemello1
Copy link
Contributor

  1. I tried using this https://github.com/pytorch/torchtune/blob/main/recipes/configs/mistral/7B_full_ppo_low_memory.yaml and gave up after 10min no first step, even after turning compile=False

  2. we shouldn't be compiling the entire model. Instead, we should use the utility that compiles per layer, like here:

    training.compile_model(model)

  3. DPO distributed doesn't compile the model. Should it?

cc: @SalmanMohammadi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants