Improve error message for eventlet/gevent monkey patching #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoolCat467
approved these changes
Nov 19, 2024
|
@yurivict would you mind testing this to make sure the better error message appears? |
graingert
previously requested changes
Nov 21, 2024
graingert
reviewed
Nov 21, 2024
Comment on lines
+2956
to
+2961
| if "eventlet" in sys.modules or "gevent" in sys.modules: | ||
| raise NotImplementedError( | ||
| "unsupported platform or primitives trio depends on are monkey-patched out", | ||
| ) | ||
| else: | ||
| raise NotImplementedError("unsupported platform") |
There was a problem hiding this comment.
maybe something like this?
Suggested change
| if "eventlet" in sys.modules or "gevent" in sys.modules: | |
| raise NotImplementedError( | |
| "unsupported platform or primitives trio depends on are monkey-patched out", | |
| ) | |
| else: | |
| raise NotImplementedError("unsupported platform") | |
| _patchers = sorted({"eventlet", "gevent"}.intersection(sys.modules.keys())) | |
| if _patchers: | |
| raise NotImplementedError( | |
| "unsupported platform or primitives trio depends on are monkey-patched out by {_patchers}", | |
| ) | |
| else: | |
| raise NotImplementedError("unsupported platform") |
There was a problem hiding this comment.
Else block is unnecessary after raise statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3087
Unfortunately I am unable to check this because I only have Linux and Windows available. This only happens on MacOS.