-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Autodeps with pre-commit? #2835
Comments
Just popping by to mention that #2790 probably will end up not making a change to how we have requirements files (at least if I have my way and there isn't a great argument for it -- I really don't like having to install a 3rd party tool globally to install requirements ... or have to make 2 venvs, one for the tool and one for the project + deps). Given that, I think making this change makes sense and shouldn't be blocked by anything! But I still don't know if we can have platform-independent lockfiles using pip-tools, which is my biggest gripe with it. |
(responded to A5rocks in #2790) |
I don't think using a manual stage would make sense, because either way we'd have to commit and push the changes which are the main issues with the current workflow. |
Manual stage would work well for re-generating the autogenerated files, I might make a pull request implementing that later. |
https://github.com/jazzband/pip-tools#version-control-integration
I don't know much about pre-commit but if we could get it to run on only a subset of commits it would replace the half-baked tool we have. Maybe using the "manual" stage? (
stages: [manual]
)The text was updated successfully, but these errors were encountered: