Make Eel work with Microsoft Edge on Linux #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfloflo
force-pushed
the
find_edge_on_linux
branch
2 times, most recently
from
a6b2963
to
5c96074
Compare
samuelhwilliams
force-pushed
the
find_edge_on_linux
branch
from
5c96074
to
1c2e291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Edge is available for Linux, at least from the Insider Channel -- see Debian package downloads and instructions.
This PR implements the general detection mode using
whichcraft.whichto findmicrosoft-edgeon Linux. The primary Edge example has been updated to reflect this, with a fallback to Chrome if Edge is not detected. The README.md has also been updated so the wording is more general and admits the option of using Edge on Linux.The primary use case I see is enabling greater consistency of behaviour across platforms, especially if #612 and/or #663 are pulled in.
The PR has been written in such a way that it should be readily compatible with @properchopsticks' PR #612 which adds the
start msedge --appoption and @doug-benn's PR #663 which aims to enable app mode for Edge based on finding the executable path on Windows, regardless of which of the these PRs is integrated first. I think they'd probably all three go well together to comprehensively cover the different ways Edge might be launched, as appropriate to the system configuration.Tested on Ubuntu 22.04 with Microsoft Edge 112.0.1722.23 beta and Windows 11 22H2 with Microsoft Edge 111.0.1661.54. Also works with Ubuntu in WSL2 for me if
--disable-gpuis passed as an additional command line argument.