Migrate AoC features and introduce a new Month-Day based season lock mechanism #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fwiw, I have a PR open on sir-lance to change AoC, might be worth implementing here and closing the sir-lance PR. |
Sure, I'll do it, I was planning to do some work on that, this weekend. |
The reimagined season lock decorator accepts a unique id, which must be defined in the `season_lock` config file. From now on, seasons can be specified using an interval, in the format of day:month to day:month. The decorator automatically handled the span between years.
Co-Authored-By: Janine vN <[email protected]> Co-Authored-By: ChrisJL <[email protected]> Co-Authored-By: Ben Soyka <[email protected]> Co-Authored-By: TizzySaurus <[email protected]> Co-Authored-By: Hassan Abouelela <[email protected]> Co-Authored-By: Matteo Bertucci <[email protected]> Co-Authored-By: Johannes Christ <[email protected]> Co-Authored-By: arl <[email protected]> Co-Authored-By: Sebastiaan Zeeff <[email protected]> Co-Authored-By: Xithrius <[email protected]> Co-Authored-By: wookie184 <[email protected]> Co-Authored-By: Joe Banks <[email protected]> Co-Authored-By: ToxicKidz <[email protected]> Co-Authored-By: decorator-factory <[email protected]>
This commit furthermore configures the aiohttp session to easily interact with the site api.
- This commits adds an APIClient to the AoC cog, and implements site as the backend storage for AoC role blocks
4 tasks
This was referenced Nov 17, 2022
|
This has been superceded by #66, sort of. The PR taking this over is a straight migration. It does not include the new seasonal-ish locking features or the migration of information to site. That will be done in future, separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Currently in Draft State, as I still need a site PR to store AoC related data there.
Edit: The PR aforementioned has been merged, it's not a blocker anymore. See..