-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more ruff rules #207
Use more ruff rules #207
Conversation
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a89af93
to
29a0b14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing comma rule seems a bit intrusive, and not always relevant (for example after a **kwargs
), but otherwise this looks good
Yea I can understand that. The linting rule likely makes more sense when used in combination with ruff format / black, as that impacts how they are formatted. Dropped that commit, and updated the config to ignore that rule. |
29a0b14
to
54e0f83
Compare
54e0f83
to
7536158
Compare
7536158
to
c72b515
Compare
This updated our ruff config to select all rules, and disable those I thought weren't useful.
The only breaking changes that I can see will affect our repos is the change to
in_whitelist_check
.Draft release notes
Breaking Changes
All breaking changes are related to making boolean default and boolean-typed positional arguments in function definition keyword args only. The arg names and functions are listed below.
sync_app_commands
inpydis_core.BotBase.load_extensions()
should_raise
inpydis_core.site_api.APIClient.maybe_raise_for_status()
fail_silently
inpydis_core.utils.checks.in_whitelist_check()
pagination_emojis, lines, ctx, embed
inpydis_core.utils.pagination.LinePaginator.paginate()
What's Changed
pydis_core.BotBase
, by @shtlrs in Document the instance attributes of BotBase #204Full Changelog: v10.7.0...v11.0.0