Allow specifying an explicit format in parse_date/parse_time #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
+ Coverage 91.28% 91.29% +0.01%
==========================================
Files 27 27
Lines 4623 4630 +7
==========================================
+ Hits 4220 4227 +7
Misses 403 403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akx
requested changes
Oct 19, 2024
babel/dates.py
Outdated
Comment on lines
1202
to
1207
| This function first tries to interpret the string as ISO-8601 | ||
| date format, then uses the date format for the locale as a hint to | ||
| determine the order in which the date fields appear in the string. | ||
|
|
||
| If an explicit format is provided, the function will use it to parse | ||
| the date instead. |
There was a problem hiding this comment.
This should note that the ISO-8601 attempt isn't done when you use an explicit format. Might need to rephrase the whole thing to make that flow nicely.
There was a problem hiding this comment.
I changed it up a bit so that it hopefully reads better now. Also added an example with an explicit format=....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1090
This uses
parse_patterninternally when a custom format is used.