Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprocess: fix stream handling #574

Open
woodruffw opened this issue Mar 23, 2023 · 2 comments
Open

Subprocess: fix stream handling #574

woodruffw opened this issue Mar 23, 2023 · 2 comments
Labels
component:dep-sources Dependency sources enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@woodruffw
Copy link
Member

#572 provides a temporary fix by doing codepoint substitution, but #573 demonstrates that our underlying poll/buffering technique is unsound: our buffering might split a unicode sequence, resulting in invalid encodings in an otherwise valid stream.

Rather than performing the poll-buffer loop ourselves, we should probably use Popen.communicate().

@woodruffw woodruffw added enhancement New feature or request component:dep-sources Dependency sources labels Mar 23, 2023
@woodruffw
Copy link
Member Author

Tagging @tetsuo-cpp for triage, feel free to reassign 🙂

@tetsuo-cpp
Copy link
Contributor

@jleightcap This one would be also be good if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:dep-sources Dependency sources enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants