You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The workflow to detect existing PRs only checks if there is an update PR for the provider. It does not check that the upstream PR corresponds to the latest upstream version of the provider.
That means that if an update PR fails and isn't closed, it will block future updates to that provider, even ones that would succeed. Examples of that blocking include:
The work-around is to close upgrade PRs as soon as they fail. This is annoying as genuine failures (an invalid release) will be re-opened every day (and must be closed every day). The alternative is to let providers get stale once they get stuck once, so we should close failed PRs.
Solution
Our tooling should be robust to bad versions, closing outdated PRs and opening new ones as necessary. I propose the following algorithm for updating metadata:
Description
The workflow to detect existing PRs only checks if there is an update PR for the provider. It does not check that the upstream PR corresponds to the latest upstream version of the provider.
That means that if an update PR fails and isn't closed, it will block future updates to that provider, even ones that would succeed. Examples of that blocking include:
Work-around
The work-around is to close upgrade PRs as soon as they fail. This is annoying as genuine failures (an invalid release) will be re-opened every day (and must be closed every day). The alternative is to let providers get stale once they get stuck once, so we should close failed PRs.
Solution
Our tooling should be robust to bad versions, closing outdated PRs and opening new ones as necessary. I propose the following algorithm for updating metadata:
"^Publish Package Metadata <provider>@.*$"
."^Publish Package Metadata <provider>@<target-version>$"
, open it.This algorithm has the following properties, all of which I believe are necessary:
The text was updated successfully, but these errors were encountered: