Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release resource should integrate with the CRD cache #3299

Open
EronWright opened this issue Oct 31, 2024 · 0 comments
Open

Release resource should integrate with the CRD cache #3299

EronWright opened this issue Oct 31, 2024 · 0 comments
Labels
area/helm kind/enhancement Improvements or new features

Comments

@EronWright
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The provider maintains a cache of CRDs across resources, to enable various resources to determine whether a given kind is namespaced. For example, the ConfigFile resource creates a child resource for each object in the manifest file, and assigns a resource base derived from the object's name. If the kind is namespaced, the context namespace (e.g. default) must be included in the name, in order to arrive at a canonical name. This, in turn, affects other features like the supported config.kubernetes.io/depends-onn annotation (ref). See #2904 for more information.

At present, the Release resource doesn't contribute to the CRD cache, because it doesn't create child resources (e.g. of type kubernetes.apiextensions.k8s.io/v1.CustomResourceDefinition).

As I outlined in #3186 (review), the Release resource should populate the CRD cache.

Affected area/feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants