Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More actionable "will contain a secret" warning #3236

Open
blampe opened this issue Sep 30, 2024 · 0 comments
Open

More actionable "will contain a secret" warning #3236

blampe opened this issue Sep 30, 2024 · 0 comments
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@blampe
Copy link
Contributor

blampe commented Sep 30, 2024

When exporting to YAML we can emit a warning "YAML will contain a secret value in plaintext" but we don't include enough information to help the user understand which specific output is leaking secrets.

if k.yamlRenderMode {
if checkedInputs.ContainsSecrets() {
_ = k.host.Log(ctx, diag.Warning, urn, "rendered YAML will contain a secret value in plaintext")
}
}

@blampe blampe added the kind/enhancement Improvements or new features label Sep 30, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 30, 2024
@blampe blampe added impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants