Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi about always shows unknown for the dotnet language plugin version #389

Open
justinvp opened this issue Nov 15, 2024 · 0 comments · May be fixed by #390
Open

pulumi about always shows unknown for the dotnet language plugin version #389

justinvp opened this issue Nov 15, 2024 · 0 comments · May be fixed by #390
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec
Milestone

Comments

@justinvp
Copy link
Member

When running pulumi about for a .NET Pulumi program, it shows unknown for the language plugin version. Instead, it should show the version of the language plugin.

GetPluginInfo is returning version.Version for the version:

func (host *dotnetLanguageHost) GetPluginInfo(ctx context.Context, req *pbempty.Empty) (*pulumirpc.PluginInfo, error) {
return &pulumirpc.PluginInfo{
Version: version.Version,
}, nil
}

But the wrong package is being used. It's using "github.com/pulumi/pulumi/sdk/v3/go/common/version" when it should be using "github.com/pulumi/pulumi-dotnet/pulumi-language-dotnet/version" as the latter package's Version variable is the one that's actually being set during build:

ldflags:
- -X github.com/pulumi/pulumi-dotnet/pulumi-language-dotnet/version.Version={{.Tag}}

@justinvp justinvp added the kind/bug Some behavior is incorrect or out of spec label Nov 15, 2024
@justinvp justinvp added this to the 0.113 milestone Nov 15, 2024
@justinvp justinvp self-assigned this Nov 15, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 15, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Nov 15, 2024
@justinvp justinvp linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants