-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rum - Create AppMonitor returns name instead of id #333
Comments
We have to put AppMonitor ID into RUM code snippet: https://github.com/aws-observability/aws-rum-web/blob/main/docs/cdn_installation.md#arguments |
I believe this is an instance where CloudControl is returning the wrong identifier back? Trying this out and capturing the payload for the requests should help. |
I've reproduced the issue and yes, it appear that AWS CloudControl uses the name as the identifier for this resource. They haven't yet added the monitor ID to the resource schema so that's not available indirectly either. Will report this upstream. |
Repro: monitor, err := rum.NewAppMonitor(ctx, "mon", &rum.AppMonitorArgs{
Domain: pulumi.String("*.example.com"),
})
if err != nil {
return err
}
ctx.Export("monid", monitor.ID())
ctx.Export("monname", monitor.Name) Outputs: Outputs:
+ monid : "mon-53833c9"
+ monname: "mon-53833c9" Relevant cloudcontrol schema sections: {
...
"properties" : {
"Name" : {...},
"Domain" : {...},
"CwLogEnabled" : {...},
"Tags" : {...},
"AppMonitorConfiguration" : {...}
},
"createOnlyProperties" : [ "/properties/Name" ],
"primaryIdentifier" : [ "/properties/Name" ],
...
} |
Can we get a link to the reported issue upstream? |
Unfortunately this reporting is via an internal channel which isn't linkable. Could I also ask what your usecase is for needing this property? Are you needing this value for use elsewhere? |
I have to modify ID in RUM code snippet: |
Hi, how is it going? Can you remove "needs-repro" label? |
Hi, https://docs.aws.amazon.com/cloudwatchrum/latest/APIReference/API_CreateAppMonitor.html Are we close to fix this issue? |
Great! It looks like the issue's been resolved upstream then. Will close this as fixed. |
Hi, can I ask where is the code change? this file is not correct: "createOnlyProperties" : [ "/properties/Name" ], why this item is closed? |
it's not fixed |
Ah my misunderstanding. I thought you were showing a screenshot of the id being returned correctly now. Will re-open. |
Hi, is there any update on resolving this issue? Unfortunately this issue is blocking me from using CloudWatchRUM. |
Hi, is there any update on this? |
No, there's not yet been a fix published upstream. |
this is not fixed yet. Can you remove label "resolution/fixed" and add "awaiting-upstream"? |
Looks like this has been fixed upstream, but is still an issue. I've created #1734 |
Hello!
Issue details
I'm creating new rum AppMonitor:
new awsnative.rum.AppMonitor("name_of_app_monitor", { domain: "*.example.com" });
and getting output where id = "name_of_app_monitor".
Based on documentation we should get all inputs and additionally unique ID for this managed resource:
https://www.pulumi.com/registry/packages/aws-native/api-docs/rum/appmonitor/#outputs
Steps to reproduce
Expected: ID
Actual: Name
The text was updated successfully, but these errors were encountered: