Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider updating typescript code to improve output declaration #13132

Open
after-ephemera opened this issue Oct 16, 2024 · 1 comment
Open

Consider updating typescript code to improve output declaration #13132

after-ephemera opened this issue Oct 16, 2024 · 1 comment
Assignees
@thoward
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec kind/documentation Improvements or additions to documentation
Milestone
0.113

Comments

@after-ephemera
Copy link

File: content/docs/iac/concepts/resources/dynamic-providers.md

It seems that per #11639 the declare keyword should be used to declare outputs on the provider so that they are properly exposed to consumers.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 16, 2024
@github-project-automation github-project-automation bot moved this to 🤔 Triage in Docs 📚 Oct 16, 2024
thoward added a commit that referenced this issue Oct 17, 2024
@thoward
Use declare keyword in TS example for dynamic resource outputs.
2f49a0c 
Per: #11639 and #13132 ... this should be using `declare`.
@thoward thoward mentioned this issue Oct 17, 2024
Closed
@thoward thoward added area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec kind/documentation Improvements or additions to documentation and removed needs-triage Needs attention from the triage team labels Oct 17, 2024
@thoward thoward moved this from 🤔 Triage to 💜 Review in Docs 📚 Oct 17, 2024
@thoward thoward added this to the 0.111 milestone Oct 17, 2024
@thoward
Copy link
Contributor

thoward commented Oct 17, 2024

Thanks for the report! I filed a PR for this #13146

@interurban interurban modified the milestones: 0.111, 0.112 Oct 30, 2024
@thoward thoward self-assigned this Nov 13, 2024
@thoward thoward modified the milestones: 0.112, 0.113 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thoward thoward

Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec kind/documentation Improvements or additions to documentation
Projects
Docs 📚
Status: 💜 Review
Milestone
0.113
Development

No branches or pull requests
4 participants
@interurban @thoward @after-ephemera @pulumi-bot