Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULP-76] Remove is highest #2039

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mdellweg
Copy link
Member

No description provided.

This allows uploads of different files claiming to be the same
collections into different repositories.

relates to pulp#1052
@mdellweg mdellweg linked an issue Nov 21, 2024 that may be closed by this pull request
@mdellweg mdellweg marked this pull request as draft November 21, 2024 10:19
@mdellweg
Copy link
Member Author

@jctanner The description about the search vector sounds scary in this context. Shouldn't search be broken, when the search vector does no longer receive updates?
Can you gauge whether this technology https://docs.djangoproject.com/en/4.2/ref/contrib/postgres/search/ would serve our purpose too?

@jctanner
Copy link
Contributor

jctanner commented Nov 21, 2024

Comment on lines 194 to 198
# a migration file. The trigger only runs when the table is
# updated. CollectionVersions are INSERT'ed into the table, so
# the search_vector does not get populated at initial creation
# time. In the import or sync workflows, is_highest gets toggled
# back and forth, which causes an UPDATE operation and then the
# search_vector is built.
# time.
search_vector = psql_search.SearchVectorField(default="")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about this search vector.

@mdellweg mdellweg changed the title Remove is highest [Pulp-76] Remove is highest Nov 27, 2024
@mdellweg mdellweg changed the title [Pulp-76] Remove is highest [PULP-76] Remove is highest Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_highest violates content immutability
2 participants