Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justl evil interaction #15

Open
vmiheer opened this issue Jun 9, 2022 · 3 comments
Open

justl evil interaction #15

vmiheer opened this issue Jun 9, 2022 · 3 comments

Comments

@vmiheer
Copy link
Contributor

vmiheer commented Jun 9, 2022

Justl works fine in emacs mode but when evil mode is on, the keybindings don't work.

  1. Magit works fine when evil is on in other buffers without any issues, similar approach could work
  2. Explicitely disable evil mode in justl mode buffers
@psibi
Copy link
Owner

psibi commented Jun 10, 2022

I would be happy to accept a PR for the same. I would be interested to see how magit approaches the problem.

Alternatively, I guess you can define a hook for justl-mode-hook where you disable the evil mode.

@kristupas-g
Copy link

Semi begginer emacs question. But would evil support be hard to implement? Imo this is all thats missing from this package

@psibi
Copy link
Owner

psibi commented Jun 26, 2022

I'm not an evil user myself, so I don't have any motivation to implement it. But I would be happy to accept a PR provided it's standalone enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants