Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network check events should be kebab-case in JSON too #76

Closed
RemiBardon opened this issue Nov 22, 2024 · 0 comments · Fixed by #80
Closed

Network check events should be kebab-case in JSON too #76

RemiBardon opened this issue Nov 22, 2024 · 0 comments · Fixed by #80
Assignees
Labels
bug Something isn't working

Comments

@RemiBardon
Copy link
Member

RemiBardon commented Nov 22, 2024

When network checks are returned in JSON, events are not kebab-case as they should be. We should fix that.

 {
     "id": "SRV-c2s",
-    "event": "DnsRecordCheckResult",
+    "event": "dns-record-check-result",
     "data": {
         "description": "SRV record for client-to-server connections",
         "status": "INVALID"
     }
 }

It's true for all network checks individually and together.

@RemiBardon RemiBardon added the bug Something isn't working label Nov 22, 2024
@RemiBardon RemiBardon self-assigned this Nov 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog & Ideas 💡 in Prose Pod API to-do list Nov 22, 2024
@RemiBardon RemiBardon moved this from Backlog & Ideas 💡 to Not Started 🕑 in Prose Pod API to-do list Nov 22, 2024
@RemiBardon RemiBardon moved this from Not Started 🕑 to In Progress 🏗️ in Prose Pod API to-do list Nov 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in Prose Pod API to-do list Nov 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in Prose Pod API to-do list Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant