Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more intelligent way of defining FIR filter length #128

Open
psurukuc opened this issue Feb 11, 2020 · 2 comments
Open

Implement more intelligent way of defining FIR filter length #128

psurukuc opened this issue Feb 11, 2020 · 2 comments
Assignees

Comments

@psurukuc
Copy link
Contributor

The current FIR filter length (while generating from TF) is done by taking 2*(circular shift) + (TF length). This works alright for most of the filters, but if the filter is really resonant it fails. Implement a better way to do this by perhaps defining both the ends of the filter where the magnitude falls below a threshold (as a fraction of the maximum magnitude of the filter ?).

@psurukuc psurukuc self-assigned this Feb 11, 2020
@arinabykadorova
Copy link
Contributor

Yes, this would be better. Perhaps a patch-up longer FIR length is okay for now, but will put this on the list.

@pslocum
Copy link
Contributor

pslocum commented Jan 7, 2022

@jkgaison65 has been able to adapt the antenna FIRs for resonant systems. So I think we can optimize the FIRs for antennas, merge to develop, and then revisit if needed when we merge the resonant calculations. In the meantime if there are additional near-term FIR changes being planned, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants