Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root find package version #21

Open
guiguem opened this issue May 28, 2019 · 1 comment
Open

Root find package version #21

guiguem opened this issue May 28, 2019 · 1 comment

Comments

@guiguem
Copy link
Member

guiguem commented May 28, 2019

If we change find_package(root 6.00) into find_package(root 7.00) in the main CMakeLists.txt, cmake will print:

-- Building submodule Cicada at /Users/mguigue/Work/Project8/SourceTree/katydid/Cicada
-- Found ROOT: /usr/local/bin/root-config (Required is at least version "7.00") 

and will go on as if everything was fine.

Found this "issue" in another project, but this should apply in every repo where we have root package...
Very low priority, but this might hide some issues with other packages...

@guiguem
Copy link
Member Author

guiguem commented May 28, 2019

A solution is to add

if (${ROOT_VERSION} VERSION_LESS 6.00)
    MESSAGE( FATAL_ERROR "Root version (${ROOT_VERSION}) smaller than 6.00")
endif()

in the FindROOT.cmake right after the ROOT_VERSION definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants