-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the UI of trip_detail #791
Change the UI of trip_detail #791
Conversation
… content_my_trip_info.xml
# Conflicts: # Android/app/src/main/res/values/strings.xml
@@ -4,7 +4,6 @@ | |||
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd"> | |||
|
|||
<module name="Checker"> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are not making any meaningful change to this file, just remove this file from your commits, because it unnecesaarily puts the Git-Blame for this file on you and this PR which shouldn't be the case.
If you're not able to checkout this file from the Git, just add the empty line again to make sure this change is lost
<!--border color and border width--> | ||
<stroke | ||
android:width="3dp" | ||
android:color="#00000000" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of direct hex code, use @color/white
@@ -34,6 +32,7 @@ | |||
<RelativeLayout | |||
android:layout_width="match_parent" | |||
android:layout_height="match_parent" | |||
android:visibility="gone" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of setting visibility to gone, just remove this piece of code.
android:visibility="gone" /> | ||
|
||
<RelativeLayout | ||
android:id="@+id/friend_whole_layout" | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content"> | ||
android:layout_height="wrap_content" | ||
android:visibility="gone"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why set this to gone?
@@ -4,7 +4,6 @@ | |||
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd"> | |||
|
|||
<module name="Checker"> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file from commit
@AminullahTajMuhammad Are you working on this? |
Closing due to inactivity. Feel free to reopen if you continue to work on this. |
Description
Change the UI of Trip details screen. Here is the UI of that screen
Fixes #705
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease
./gradlew checkstyle
Checklist: