Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the UI of trip_detail #791

Conversation

AminullahTajMuhammad
Copy link
Contributor

@AminullahTajMuhammad AminullahTajMuhammad commented Nov 12, 2019

Description

Change the UI of Trip details screen. Here is the UI of that screen
travel-mate-ui-changes

Fixes #705

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@@ -4,7 +4,6 @@
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are not making any meaningful change to this file, just remove this file from your commits, because it unnecesaarily puts the Git-Blame for this file on you and this PR which shouldn't be the case.
If you're not able to checkout this file from the Git, just add the empty line again to make sure this change is lost

<!--border color and border width-->
<stroke
android:width="3dp"
android:color="#00000000" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of direct hex code, use @color/white

@@ -34,6 +32,7 @@
<RelativeLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:visibility="gone"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting visibility to gone, just remove this piece of code.

android:visibility="gone" />

<RelativeLayout
android:id="@+id/friend_whole_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content">
android:layout_height="wrap_content"
android:visibility="gone">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set this to gone?

@@ -4,7 +4,6 @@
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file from commit

@Swati4star
Copy link
Member

@AminullahTajMuhammad Are you working on this?

@Swati4star
Copy link
Member

Closing due to inactivity. Feel free to reopen if you continue to work on this.

@Swati4star Swati4star closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Trip Details Page UI
3 participants