Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #801 and #656 #802

Closed
wants to merge 1 commit into from
Closed

fix #801 and #656 #802

wants to merge 1 commit into from

Conversation

HeinKhantZaw
Copy link
Contributor

Description

I set the screen orientation to portrait to fix these issues.

Fixes #801 and #656

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Swati4star
Copy link
Member

@HeinKhantZaw This isn't the correct way to fix the orientation issues.

We want our app to support both (portrait and landscape) modes.

@HeinKhantZaw
Copy link
Contributor Author

Ok. I will find another solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fragment_citylist doesn't work in landscape mode[BUG]
2 participants
@HeinKhantZaw @Swati4star