Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show offline maps in the navigation drawer #534

Open
Swati4star opened this issue Oct 23, 2018 · 8 comments
Open

Show offline maps in the navigation drawer #534

Swati4star opened this issue Oct 23, 2018 · 8 comments

Comments

@Swati4star
Copy link
Member

The user is unable to access/delete the offline maps

How to save map offline?

  • go to any city in destinations
  • select city map and then select the save icon

Expected behaviour

  • add a new option in the main navigation drawer: Offline data
  • If there are no offline maps, show Oops! You don't have any offline maps saved
  • If the user has saved offline maps, show the list here.
  • There should also be an option to delete them
@ajaypro
Copy link

ajaypro commented Oct 28, 2018

Hi Swathi, I will work on this issue

@Swati4star
Copy link
Member Author

Sure @ajaypro 👍

jtj9817 added a commit to jtj9817/SideProjects that referenced this issue Oct 30, 2018
Started working on Travel-Mate Android application, particularly on this issue: project-travel-mate/Travel-Mate#534
@jtj9817
Copy link
Contributor

jtj9817 commented Oct 30, 2018

Hey, mind if I help on this issue? I can help on having a starting point for the feature.

@ajaypro
Copy link

ajaypro commented Oct 30, 2018

Hey sure, you can post it i'm also working to complete it

jtj9817 added a commit to jtj9817/Travel-Mate that referenced this issue Oct 30, 2018
Starting point for project-travel-mate#534

Added the 'Offline Maps' section to the Navigation Drawer complete with the icon. 'fragment_offlinemaps.xml' and 'OfflineMapsFragment.java' also created.
@ajaypro
Copy link

ajaypro commented Nov 3, 2018

Hi Swati, I'm stuck with saving the Geopoint in room as I have also created a type converter but yet I'm not able to resolve it, is that I can get some help.

@Swati4star
Copy link
Member Author

Can you create a work in progress PR? It'll be easier to look into problem then. @ajaypro

@ajaypro
Copy link

ajaypro commented Nov 4, 2018

sure

@ajaypro
Copy link

ajaypro commented Nov 4, 2018

I have created a PR and mentioned what I have done.

jtj9817 added a commit to jtj9817/Travel-Mate that referenced this issue Nov 19, 2018
jtj9817 added a commit to jtj9817/Travel-Mate that referenced this issue Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants