Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Elegant Python Code #2

Open
0x48piraj opened this issue Sep 28, 2018 · 5 comments
Open

Write Elegant Python Code #2

0x48piraj opened this issue Sep 28, 2018 · 5 comments
Labels
enhancement New feature or request hacktoberfest invalid This doesn't seem right up-for-grabs

Comments

@0x48piraj
Copy link
Member

  • Remove extra iteration of code in __init__.py and abuse.py
  • Re-structure code
  • Add a seperate dataset.py for collected data
@0x48piraj 0x48piraj added bug Something isn't working invalid This doesn't seem right enhancement New feature or request hacktoberfest and removed bug Something isn't working labels Sep 29, 2018
@0x48piraj 0x48piraj changed the title Write Elegant Code Write Elegant Python Code Sep 30, 2018
@savitoj98
Copy link

Can i work on this?

@rob-deans
Copy link
Contributor

Likewise, would like to work on this, do you want to split this up into more issues to address exactly what you want to happen?

@gilesv
Copy link

gilesv commented Oct 3, 2018

I'll be working on a better way to structure the dataset, maybe it could be in a separate text file and not simply hardcoded in the source code, right?

@rob-deans
Copy link
Contributor

Could have a csv so that it can also store the meanings for each one as well?

@0x48piraj
Copy link
Member Author

You can go on. Creating seperate file for this. Use en as they are in English. We will expand it. There is a issue going on for different languages. Let's finalize that and start working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest invalid This doesn't seem right up-for-grabs
Projects
None yet
Development

No branches or pull requests

4 participants